Closed flackou closed 6 years ago
Thanks for the PR @flackou
Thanks so much for this one, @flackou and @mnoack!
I'd love to see a new release of the geokit-rails
gem with this included so that we can silence the deprecation warning in our Rails 5.2 apps without needing to point our Gemfiles at master
. Let me know if there's anything I can do to help out with that.
@nholden @flackou - I've just released a gem for the latest code. I've also added ruby 2.4/rails 5 to the travis test suite.
Thanks so much, @mnoack! Works great. 🎉
Starting from Rails 5.2, there's a deprecation warning on using raw SQL fragments in some AR methods, including
order
, cf Rails 5.2 changelog :The warning precises :
We just need to wrap the SQL in
Arel.sql(...)
to remove the warning. Tests config is also fixed for Rails >= 4 (fixing #129).