search

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.
MIT License
1.57k stars 245 forks source link

Enhanced ActsAsMappable#in_bounds to allow the query to include thing… #139

Closed denisahearn closed 5 years ago

denisahearn commented 6 years ago

…s that are located on the rectangular bounds, via an "inclusive" option (defaults to false).

coveralls commented 6 years ago

Coverage Status

Coverage increased (+1.2%) to 85.614% when pulling dc52dc3871254a6cf8594135a5a02488af401936 on SenteraLLC:dpa-in-bounds-inclusive-option into 93b7153ce73a21ec139cca056c7250e0211f28f2 on geokit:master.

denisahearn commented 5 years ago

Just checking to see if this PR can get merged into this project? Thanks.

mnoack commented 5 years ago

@denisahearn - Sorry I haven't responded timely. I think I'll need to find help amongst people contributing to review PRs going forward and I no longer use geokit so it's best to be done by those using geokit.

So if you were available to occasionally review geokit PRs (given they'll affect you, generally positively as the tests are fairly comprehensive) then please accept the invite to become a committer and feel free to merge this PR.

denisahearn commented 5 years ago

@mnoack Thanks for responding, I've accepted your invitation. Yes, I would be willing to help review PRs for geokit-rails. I will merge my PR. Do you plan to still be the person to release new versions of the gem? It looks like there are a few commits to master since version 2.3.1 was released last May, and I'm curious to know when a new version with my commit will be released to rubygems.org.

mnoack commented 5 years ago

You're welcome to release gems, I think the process was a standard process like updating the version.rb file and then "bundle exec rake release" or something, feel free to "rake -T" and look for the obvious one.

My general approach was not to release after every PR, but generally as people requested it, as after-all people can point their gemfiles to the github master, this way I felt it got a bit of "testing" that way before publishing, but it really is your call now.