[FEATURE] include redshift adapter to support geolocation

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.

MIT License

1.57k stars 245 forks source link

[FEATURE] include redshift adapter to support geolocation #141

Open estebance opened 5 years ago

estebance commented 5 years ago

I have some data stored on a Redshift cluster, I wasn't able to use the tool using that tool so I've integrated the adapter and the gem to support the connection

coveralls commented 5 years ago

Coverage decreased (-36.9%) to 47.471% when pulling 8b8a0f1f3049b6cd908c3e2273ed71be7fca0dae on estebance:master into 93b7153ce73a21ec139cca056c7250e0211f28f2 on geokit:master.

ryankopf commented 1 year ago

Tests should be included with PR to consider merging. Please supply appropriate tests or this PR will be closed.

I don't think there's quite enough demand for much time to be put on this PR unless such demand can be demonstrated, and so without tests this PR is likely to be denied as the requested features can be patched in easily with an initializer appropriate for your use case.