Provide support for PostGIS, fixed deprecation warning.

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.

MIT License

1.57k stars 245 forks source link

Provide support for PostGIS, fixed deprecation warning. #144

Closed jackhayter closed 1 year ago

jackhayter commented 5 years ago

This request addresses the following two problems:

1) PostGIS was not supported, so the adaptor for Postgres was simply duplicated with a new name

There's definitely better integration that can be achieved with native PostGIS methods, but I'm not experienced enough to do that

2) Fixed a deprecation warning ahead of Rails 6

String interpolation is going to become unsupported soon, so the safer placeholder substitution was used instead

coveralls commented 5 years ago

Coverage decreased (-0.5%) to 83.871% when pulling 5cf0201fcf1e8db4a6699f8748e5c53dc0ec9b88 on decathloncanada:master into 93b7153ce73a21ec139cca056c7250e0211f28f2 on geokit:master.

coveralls commented 5 years ago

Coverage decreased (-0.5%) to 83.871% when pulling 5cf0201fcf1e8db4a6699f8748e5c53dc0ec9b88 on decathloncanada:master into 93b7153ce73a21ec139cca056c7250e0211f28f2 on geokit:master.

coveralls commented 5 years ago

Coverage decreased (-0.5%) to 83.871% when pulling 5cf0201fcf1e8db4a6699f8748e5c53dc0ec9b88 on decathloncanada:master into 93b7153ce73a21ec139cca056c7250e0211f28f2 on geokit:master.

coveralls commented 5 years ago

Coverage decreased (-0.5%) to 83.871% when pulling 5cf0201fcf1e8db4a6699f8748e5c53dc0ec9b88 on decathloncanada:master into 93b7153ce73a21ec139cca056c7250e0211f28f2 on geokit:master.

ryankopf commented 1 year ago

Currently not accepting new adapters unless the implementation comes with tests, because they can easily be added via an initializer.

However I have noted the other changes and implemented them as requested, with corrections.