search

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.
MIT License
1.57k stars 245 forks source link

Arel::SqlLiteral has been moved in rails 42 #65

Closed pzgz closed 9 years ago

pzgz commented 9 years ago

You will get following error:

NameError - uninitialized constant Arel::SqlLiteral:
  activesupport (4.2.0.rc2) lib/active_support/dependencies.rb:533:in
`load_missing_constant'
  activesupport (4.2.0.rc2) lib/active_support/dependencies.rb:184:in
`const_missing'
  geokit-rails (2.0.1) lib/geokit-rails/acts_as_mappable.rb:237:in
`distance_conditions'
  geokit-rails (2.0.1) lib/geokit-rails/acts_as_mappable.rb:108:in
`within'

Actually, this has been removed once in arel gems at 5.0 once but add back, and it looks like they decide to remove it again in 6.0. I think the safe way is to use SqlLiteral from Arel::Nodes module.

mattschutt commented 9 years ago

Any chance we can get a release for this? I would like to be able to move some enhancements into production and currently building against master instead of a release prevents me. Thanks

mnoack commented 9 years ago

Sorry for the late reply. I've just merged a few PR's in and released geokit-rails-2.1.0