search

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.
MIT License
1.57k stars 245 forks source link

Geo Scope method added #81

Closed amit4m2008 closed 8 years ago

amit4m2008 commented 9 years ago

Added the geo_scope method for old gem support.

mnoack commented 9 years ago

A few things. Can you tell me why it should support an old method?

Once you've done that you'll need to add appropriate tests and the method itself looks a bit complex so perhaps sub-components should become private methods or the method could be extracted into a class.

mnoack commented 8 years ago

Closed as it's got conflicts, and it was failing tests. If you can rebase this off master, resolve conflicts, and the tests pass I'll reconsider the PR.