search

geokit / geokit-rails

Official Geokit plugin for Rails/ActiveRecord. Provides location-based goodness for your Rails app. Requires the Geokit gem.
MIT License
1.57k stars 245 forks source link

Add NOT NULL checks for latitude and longitude #86

Closed jensb closed 8 years ago

jensb commented 8 years ago

... otherwise nonsense values are being returned for distance calculations involving such objects. Added a test fixture without latitude and longitude to make existing tests fail if they do not test for NULL lat/lng values.

jensb commented 8 years ago

Please look at the Travis CI failures, they are not caused by my code. Thanks!

mnoack commented 8 years ago

You're right. I tried to have a quick look at the CI failures but it seems it's getting rather complex and I'll need to spend some time ensuring it works correctly in all ruby/rails versions before I release the next version of the gem.

jensb commented 8 years ago

Good :-), because I have another PR pending (add bounding box around within) and I wanted to make sure this is finished to avoid conflicts. Thank you!