geokrety / geokrety-website

Open source item tracking for all caching platforms - This is the actual code beside geokrety.org
https://geokrety.org
MIT License
12 stars 18 forks source link

Increase API limits for active users #1053

Open okainov opened 2 months ago

okainov commented 2 months ago

From #941

aybe add some "tiers", so users who are active/old/have some GK in inventory get bigger API limit? While anonymous or newbies get default one (which can be even less than 1500). I would imagine that if the limit is bigger than, let's say 50*(amount of GKs in inventory), it should be quite fine even with most active folks (I think if you check profiles of the users already posted here, you'll see that they have hundreds of GKs in their hands if not thousand)

SDymon commented 2 months ago

I would appreciate it if you would inform us about the implementation of such a possibility here. It is extremely inconvenient to calculate the daily limit and mark GK taking into account the existing limit!

kumy commented 2 months ago

This is not an easy issue. Will take time to think about it and implement properly. The ratelimit system doesn t use the postgres db itself, but work with redis and http requests. Thus preserving system resources.

(Also I will take some vacations and won't be there for support if anything goes wrong because of a new feature e.g. #1151)

I have to admit I also have concerns about such way of "playing". Looks like some players are mostly mass creating GK, rarely dropping them and dip every time - to have a high stat counter? Where is the interaction with other players? Goal is to share objects, having them going for cache to cache and players' hands to other hands... Yearly badges are impacted by this. This is also something we should rethink [in another issue] - I already created new badges to reward the "droppers" - I had many complaints about this.

SDymon commented 1 week ago

This is not an easy issue. Will take time to think about it and implement properly. The ratelimit system doesn t use the postgres db itself, but work with redis and http requests. Thus preserving system resources.

(Also I will take some vacations and won't be there for support if anything goes wrong because of a new feature e.g. #1151)

I have to admit I also have concerns about such way of "playing". Looks like some players are mostly mass creating GK, rarely dropping them and dip every time - to have a high stat counter? Where is the interaction with other players? Goal is to share objects, having them going for cache to cache and players' hands to other hands... Yearly badges are impacted by this. This is also something we should rethink [in another issue] - I already created new badges to reward the "droppers" - I had many complaints about this.

Hi! Are there any changes in the geokrets mark limits? Is it possible to increase the limit to at least 5000?