geokrety / geokrety-website

Open source item tracking for all caching platforms - This is the actual code beside geokrety.org
https://geokrety.org
MIT License
12 stars 18 forks source link

Replace `GK Hotel` by `Caches with exceptional GK activity` #393

Open kumy opened 5 years ago

kumy commented 5 years ago

Raised on support mail by user decabu:

How I can register on your site my GG hotels and other from our country? Link for my GK hotels https://geocaching.su/?pn=101&cid=22853 https://geocaching.su/?pn=101&cid=22854

okainov commented 5 years ago

image

I don't really understand what is the problem here =)

kumy commented 5 years ago

problem is how to have caches listed here : https://geokrety.org/molehole.php

okainov commented 5 years ago

I didn't know that you handle GK Hotels in some special ways.

Also I see there is TR17200 mentioned on this page, how did it get there?

From gc.su side we have special attribute for gk hotels as well as often "[GK Hotel]" is in the title (but not always, probably). We can add it to our api endpoint so GK can understand that some caches are GK hotels.

kumy commented 5 years ago

OK, they are hardcoded values https://github.com/geokrety/geokrety-website/blob/d526607261a76644c5e52853535e7cfb69fde1cb/website/molehole.php#L38-L46

Note: changes here need to be also reported on new-theme branch https://github.com/geokrety/geokrety-website/blob/8ae754a8d7b4c9c03fd8bf4ca0fe3695bb0fb181/website/molehole.php#L13-L21

kumy commented 5 years ago

From gc.su side we have special attribute for gk hotels as well as often "[GK Hotel]" is in the title

If we have this filed in our db then it will be quite easy to have this list dynamically generated. What about other partners :/ (OC websites)

kumy commented 5 years ago

Here is our db entry for cache TR17200 Screenshot from 2019-06-09 12-00-51

okainov commented 5 years ago

they are hardcoded values

Oh my god -_\

Then probably there are several steps here:

But TBH I don't really see the benefit of somehow highlighting "GK hotels" caches. GK as a service supports whatever caches, so it should be good enough. Maybe it will be more useful to highlight caches with exceptional GK activity in them (which are probably exactly GK hotels), but you don't need additional data from platforms.

kumy commented 5 years ago

Added new cache to the list, so user is happy. Let's continue discussing the feature.

kumy commented 5 years ago

Maybe it will be more useful to highlight caches with exceptional GK activity in them (which are probably exactly GK hotels)

@okainov may you go deeper in this idea, I don't really understand. What is exceptional GK activity?

kumy commented 5 years ago

I imagine we may display also them as markers in the Map. Helping users to find caches hotels around them - whichever the network it is -

okainov commented 5 years ago

What is exceptional GK activity?

You have logs and waypoints tables, so you can see, which waypoints(caches) are really popular. And my assumption is that popular caches are exactly the gk hotels.

I mean something like this SELECT wp_id, count(*) as cnt from geokrety_waypoints LEFT JOIN geokrety_logs on geokrety_logs.waypoint_id=geokrety_waypoints.id GROUP BY wp_id ORDER BY cnt DESC with optional WHERE geokrety_logs.date < NOW() - 1 month