search

geokrety / geokrety-website

Open source item tracking for all caching platforms - This is the actual code beside geokrety.org
https://geokrety.org
MIT License
12 stars 18 forks source link

Allow users to manually fix or override the country for a selected waypoint/move #636

Open okainov opened 3 years ago

okainov commented 3 years ago

Which point of view do GK use when defining countries? I've just been in South Ossetia and noticed GK determines country as Georgia. Probably similar things can be noticed in Abkhazia and Crimea as well. Do you have some well-defined point of view, is it in line with some particular country point of view?

See https://geokrety.org/konkret.php?id=41811

I personally think multiple options should exist so all folks can be relatively happy seeing whatever they like. Maybe introduce some special "disputed" country with special flag or allow to have multiple countries in one point?

kumy commented 3 years ago

Really complex topic.

This remind me https://github.com/geokrety/geokrety-website/issues/593#issuecomment-801192425

The data source used in GKv1 and GKv2 is from https://github.com/urbanetic/srtm-server

The data file polygons.properties is available under a Creative Commons Attribution-Share Alike License in accordance with the license from https://github.com/bencampion/reverse-country-code. It was copied and fixed from daveross/offline-country-reverse-geocoder

If we find a good data source, where where disputed territories are represented twice, we could imagine some use in the UI.

That being say, current implementation doesn't allow users to manually fix or override the country for a selected point. (I'll rename the issue in such way.)

okainov commented 3 years ago

Is the current datasource somehow manually modifiable? I mean, there are not so many questionable territories (at least relatively famous ones: Kosovo, Crimea, South Ossetia, Abkhazia, Taiwan, Nagorny Karabakh, Transnistria, Donetsk/Lugansk regions, Northern Cyprus, Palestine, maybe Macao/Hongcong, see also https://en.m.wikipedia.org/wiki/List_of_states_with_limited_recognition ) so if manual edit is possible, it should be easy to just add second entries for such places.

Just allowing users to manual edit would lead to too much inconsistency IMO,. it's better to handle it on website logic level...

kumy commented 3 years ago

Feel free to try… https://github.com/bencampion/reverse-country-code/tree/master/src/main/resources

kumy commented 3 years ago

As in https://github.com/geokrety/geokrety-website/issues/593 we have detected that some waypoints have different detected countries, so datasources are different. Now I remember that I have worked some years ago with https://www.naturalearthdata.com/ (especially https://www.naturalearthdata.com/downloads/50m-cultural-vectors/) to use their data. Unfortunately I seem to not have documented how I've imported countries data. :(