search

geolessel / react-phoenix

Make rendering React.js components in Phoenix easy
http://reactphoenix.com
MIT License
504 stars 38 forks source link

How to get it working in IE EDGE #16

Closed dav11d closed 7 years ago

dav11d commented 7 years ago

Copied everything from the video (https://www.youtube.com/watch?v=icwjAbck8yk)

Everything working fine in chrome/firefox but doesn't want to appear in IE EDGE,

I can see the Div in the dom explorer but nothing after that.

Showing SCRIPT438: Object doesn't support property or method 'forEach' in the console.

Now I've tried using 'import babel-polyfill' in the top of my app.js , but then it doesn't render in chome/firefox and is still showing blank in IE edge.

Apologies if this is a babel/react set up issue, I'm new.

scmx commented 7 years ago

Please try this patch https://github.com/geolessel/react-phoenix/pull/4. {:react_phoenix, github: "scmx/react-phoenix", ref: "d1537be1855e9e555716c1380448337d8958140c"}

dav11d commented 7 years ago

Still having the same issue I'm afraid

scmx commented 7 years ago

Make sure the updated package is used mix deps.clean react_phoenix && mix deps.get And make sure the updated npm package is used rm -rf node_modules/react-phoenix npm install Or if phoenix 1.3 (cd assets; rm -rf node_modules/react-phoenix) (cd assets; npm install)

dav11d commented 7 years ago

Thats the one, all working now 👍

geolessel commented 7 years ago

@dav11d @scmx That PR has been merged into master. I will work on cutting a new release as soon as I get a chance.