Enable setting additional HTML attributes on container

geolessel / react-phoenix

Make rendering React.js components in Phoenix easy

http://reactphoenix.com

MIT License

504 stars 38 forks source link

Enable setting additional HTML attributes on container #42

Closed lustrousgorilla closed 4 years ago

geolessel commented 5 years ago

@lustrousgorilla Thanks for the PR and I like the idea. However, before merging there are a few things that it needs before I consider it complete:

A PR description would be helpful for future devs looking through PRs (and any looking right now)
The change/feature isn't mentioned in the documentation. Please describe the usage there.
From the looks of it, I think this would break the @spec of the function. Please update that.
There is no accompanying test. Please add one.

geolessel commented 5 years ago

@lustrousgorilla I just remembered that I did some similar work in a branch here. Check out https://github.com/geolessel/react-phoenix/compare/more-options and let me know if those changes would work for you. If so, I may just open up a PR of those changes and merge that in.

andrewmurph commented 5 years ago

@geolessel I like those changes!

lustrousgorilla commented 5 years ago

@geolessel sorry for taking a week to reply, but yeah those changes will do the trick!

geolessel commented 4 years ago

Closed in favor of #45