search

geolessel / react-phoenix

Make rendering React.js components in Phoenix easy
http://reactphoenix.com
MIT License
504 stars 38 forks source link

Support phoenix_html 3.0 #58

Closed mfilej closed 2 years ago

mfilej commented 3 years ago

This updates the version requirement for phoenix_html to include 3.0.

The tests are passing and things seem ok after a quick sanity check. Will do further testing once this reaches our staging servers.

I'm not sure you want all these updates to mix.lock - let me know if you want to reduce them down to just phoenix_html (or not even that)?

geolessel commented 2 years ago

@mfilej Thanks so much for the PR and sorry for the delays in getting this reviewed. Were you able to test on staging?

Will do further testing once this reaches our staging servers.

I have another person doing a bit of testing, but I think this will be good to go early next week.

mfilej commented 2 years ago

@geolessel No worries. Unfortunately we haven't had the chance to use this internally as the project has been put on hold.

geolessel commented 2 years ago

❤️

Closes #61