geolexica / geolexica-server

Generalized backend for Geolexica sites
2 stars 1 forks source link

Support multiple authoritative sources #151

Open skalee opened 3 years ago

skalee commented 3 years ago

Authoritative source may be composed of multiple items (e.g. in some IEV concepts), and this needs to be supported. From https://github.com/glossarist/iev-data/pull/74:

skalee:

Since this pull request authoritative_source became an array. Bug or intended? If the latter, it will require corresponding changes in sites too. The failing spec is because of this change.

For example 112-01-01 fra before:

  authoritative_source:
    ref: ISO/IEC Guide 99:2007
    clause: 1.1, modifié – Suppression de NOTE 3 et NOTE 4, et quelques modifications
      dans les autres.
    link: https://www.iso.org/standard/45324.html

and now (note a leading dash in 2nd LOC):

  authoritative_source:
  - ref: ISO/IEC Guide 99:2007
    clause: '1.1'
    link: https://www.iso.org/standard/45324.html
    relationship:
      :type: :modified
      :modification: Suppression de NOTE 3 et NOTE 4, et quelques modifications dans
        les autres.
    original: ISO/IEC Guide 99:2007, 1.1, modifié – Suppression de NOTE 3 et NOTE
      4, et quelques modifications dans les autres.

ronaldtse:

This is intended because the SOURCE field apparently has multiple sources listed, and we need to separate them one by one.

skalee commented 3 years ago

@ronaldtse How to present:

  1. Multiple authoritative sources at concept level (green)?
  2. Multiple authoritative sources at localized concept level (blue)?

Should I separate them with comma, semicolon, or maybe simply double the "SOURCE" word or do something else?

Zrzut ekranu 2021-02-17 o 11 24 05
skalee commented 3 years ago

Side note: multiple source happens to English and French localized concepts only, at least for now.

ronaldtse commented 3 years ago

This is a great question. Maybe have the multiple sources as a list under "SOURCE"? I feel that multiple instances of the word "SOURCE" will be confusing

skalee commented 3 years ago

IMO vertical list for green box, horizontal comma-separated or semicolon-separated list for blue.

strogonoff commented 1 year ago

@HassanAkbar if we already support multiple authoritative sources, then this issue can probably be closed!

HassanAkbar commented 1 year ago
  1. Multiple authoritative sources at concept level (green)?

@strogonoff Currently we are showing the first authoritative source from the eng language of the concept, and in the glossarist model there is no option to set sources at concept level. So I'm not sure if we should close this yet.

ronaldtse commented 1 year ago

@HassanAkbar then can we ensure:

  1. Glossarist model supports sources (multiple) at the localized concept level
  2. Glossarist model supports sources (multiple) at the concept level
  3. Update the Geolexica gem to display those sources
HassanAkbar commented 1 year ago

@ronaldtse

  1. Glossarist model supports sources (multiple) at the localized concept level

Yes

  1. Glossarist model supports sources (multiple) at the concept level

No, currently glossarist model does not support sources at concept level.

  1. Update the Geolexica gem to display those sources

https://github.com/geolexica/jekyll-geolexica/issues/14 Here is the ticket for updating Jekyll-geolexica gem to use glossarist model. Waiting for the implementation of glossarist model v2 before implementing this.

ronaldtse commented 1 year ago

No, currently glossarist model does not support sources at concept level.

Can you please help implement this?

Here is the ticket for updating Jekyll-geolexica gem to use glossarist model. Waiting for the implementation of glossarist model v2 before implementing this.

Yes let's do it.