geolexica / geolexica-server

Generalized backend for Geolexica sites
2 stars 1 forks source link

In SOURCE, when there are no `modifications`, do not show semicolon #181

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

https://isotc204.geolexica.org/concepts/3.1.5.2/

Screen Shot 2022-08-11 at 9 41 17 AM
HassanAkbar commented 2 years ago

@ronaldtse I have opened a PR to remove the ;. But the ; is to separate multiple sources and not for separating modification. Currently we are not showing modification from the concepts if it is a key in .yaml file, modification will only be shown if it is with the clause e.g

will not show the modification

- type: authoritative
    origin:
      ref: ISO/TS 14812:2022
      clause: 3.1.1.1
      link: https://www.iso.org/standard/79779.html
    modification: "some modification"

will show the modification

- type: authoritative
    origin:
      ref: ISO/TS 14812:2022
      clause: 3.1.1.1, modified - some modification
      link: https://www.iso.org/standard/79779.html
ronaldtse commented 2 years ago
      clause: 3.1.1.1, modified - some modification

Is definitely not the correct treatment. We should always separate the modification away from the clause, because the clause is meant to be machine-readable.

HassanAkbar commented 2 years ago

@ronaldtse Got it, should I update the structure of the source (currently <a href="#{link}">#{ref}</a>, #{clause}) to include modification?

If yes, then what should be the format?

ronaldtse commented 2 years ago

The rendering format should be:

[SOURCE: ISO/TS 14812:2022, 3.1.1.1, modified -- {some modification}]