search

geolexica / isotc211-glossary

ISO/TC 211 MLGT Online Concepts
2 stars 8 forks source link

Broken language codes #16

Open skalee opened 4 years ago

skalee commented 4 years ago

Some languages are broken after migration.

They have been fixed in Excel recently (as in https://github.com/geolexica/isotc211.geolexica.org/issues/110).

ronaldtse commented 4 years ago

Maybe this is related to Glossarist? Ping @strogonoff

ronaldtse commented 4 years ago

@strogonoff will update this in the Glossarist Desktop.

strogonoff commented 4 years ago

@ronaldtse Can we change IEV to match the codes?

strogonoff commented 4 years ago

Unassigning myself as codes in Glossarist Desktop is a separate concern (https://github.com/glossarist/glossarist-desktop/issues/49)

ronaldtse commented 4 years ago

@ronaldtse Can we change IEV to match the codes?

Yes!

skalee commented 4 years ago

Do you mean that you want to replace valid ISO 639-2 codes used in IEV with invalid ones used in TC211 glossary? Doesn't sound like a good idea. I can adapt though.

ronaldtse commented 4 years ago

I meant we should change everything to the correct codes.

strogonoff commented 4 years ago

invalid ones used in TC211 glossary

I thought ISO/TC 211 glossary uses correct language codes as of https://github.com/geolexica/isotc211.geolexica.org/issues/110 🤔

skalee commented 4 years ago

They have been fixed in spreadsheets recently (https://github.com/geolexica/isotc211.geolexica.org/issues/110 indeed), but these changes were somehow reverted at data migration.

strogonoff commented 4 years ago

Ah was that because Glossarist Desktop was still using the wrong language codes at the time of migration? Sorry if that.

Now that the app was updated to use the correct codes, let me run another migration against my fork of this repo. I expect the diff should be much smaller, since YAML is going to be dumped using the same formatting. I’ll check if that’s the case and will make a PR.

The other way to fix this would be to run a Ruby script to migrate YAML. If anyone is on to that already, please do let me know and re-assign to yourself (then I won’t do language migration in the app)

ronaldtse commented 4 years ago

I think a global regex replace would be super easy...?

skalee commented 4 years ago

I can do a pull request.

skalee commented 4 years ago

Wow, I'm confused. It looks like this repo already uses corrected codes, both in tc211-termbase.meta.yaml and in concepts. Also removing my temporary fixes which I did in TC 211 site does not break anything.

For sure there were no fixes in recent days. I don't know, maybe I was working on some broken branch of the glossary or something…

strogonoff commented 4 years ago

Oh right, indeed. @skalee Could you confirm there are no leftover wrong language codes on some concepts? This should be doable with a grep or a Ruby script, I suppose…

skalee commented 4 years ago

Yes @strogonoff, I confirm that there are no broken codes in concepts/concept-*.yaml nor in tc211-termbase.meta.yaml nor in register.yaml nor in change-requests/*. I suppose this issue should be closed now. Thank you!