search

geolexica / isotc211-glossary

ISO/TC 211 MLGT Online Concepts
2 stars 8 forks source link

Extracting domain from terms #34

Closed HassanAkbar closed 4 months ago

HassanAkbar commented 1 year ago

As discussed here -> https://github.com/geolexica/isotc211.geolexica.org/issues/200#issuecomment-1768258038

ronaldtse commented 6 months ago

@HassanAkbar can we merge this (or is this superseded?)

HassanAkbar commented 6 months ago

@ronaldtse Let me check, I'll get back to you on this.

HassanAkbar commented 6 months ago

@ronaldtse we still need to extract the domains from the concepts but this PR is no longer valid as this is updating old data,

What I'm thinking is to update the tc211-termbase gem to extract the domains when generating concepts rather than doing it afterwards on the generated concepts. I'll open a PR in tc211-termbase for this change.

ronaldtse commented 4 months ago

@HassanAkbar is this supposed to be closed? Is the work done? Thanks.

HassanAkbar commented 4 months ago

@ronaldtse This is not needed as this is updating old concepts, I've created a new issue for this and will open a new PR.