geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

Incorrect language codes for Chinese, Dutch, and German #110

Closed skalee closed 4 years ago

skalee commented 4 years ago

Perhaps incorrect codes should be replaced in concept preprocessing, perhaps https://github.com/geolexica/tc211-termbase/ should be fixed instead. The former is trivial, the latter is way better, but I am not sure if it's that simple.

Likely there are more issues like that. This project's lang.yml should be replaced with one from geolexica/geolexica-server (or inherited somehow). But concept data needs to be fixed prior that or site will break.

ronaldtse commented 4 years ago

@skalee where does it say that zho is preferred over chi?

ronaldtse commented 4 years ago

https://www.loc.gov/standards/iso639-2/php/code_list.php

You are right:

Screen Shot 2020-05-14 at 8 46 23 PM

(T) is for terminology.

I can get them changed in the original data file.

skalee commented 4 years ago

I believe only these three mentioned in the first post are incorrect. Apart from that, there are issues with short codes, but they doesn't require addressing in the original files.

skalee commented 4 years ago

I'll update codes in termbase gem in the meantime.

ronaldtse commented 4 years ago

Thanks @ReesePlews for updating the MLGT with the corrected terminology codes!

ReesePlews commented 4 years ago

@skalee, @ronaldtse thanks for identifying this issues. they have been corrected in the MLGT Release 5 source i am preparing to send for insertion into Geolexica.