search

geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

Glossary is always updated to the latest master on deploy #141

Open skalee opened 4 years ago

skalee commented 4 years ago

Although we use Git submodules for tracking version of the glossary, both build and deploy scripts always attempt to update the glossary by executing make update-modules, which is equivalent to git submodule foreach git pull origin master.

That means that any change pushed to the master branch of https://github.com/geolexica/isotc211-glossary will go live next time site is deployed. Glossary development becomes tightly coupled with site development. This will cause problems when we decide to hold on with releasing new glossary for whatever reason (breaking changes, bugs, pending reviews, etc.). We can't even deploy a tiny bugfix without deploying glossary updates.

That wasn't a problem before. Ongoing glossary development was happening in spreadsheets. New commits in isotc211-glossary repo were occasional, they were resulting either from of spreadsheet release or parser release. Now it seems different.

So — what to do, @ronaldtse, @strogonoff?

ronaldtse commented 4 years ago
  1. The goal is to eventually allow the app to directly deploy the website.
  2. Updates to the repo will be more frequent from now on since the release mechanism is now changed from spreadsheet release to change requests via the app. We need to enable some test/gating method so that the site doesn't break even if the data breaks, and enable some tests so that the data doesn't break.
skalee commented 4 years ago

Perhaps we should deploy the latest release rather than current master?

ronaldtse commented 4 years ago

Maybe, we could bind the release to the latest approved change request? Thoughts @strogonoff ?