Open skalee opened 4 years ago
I see no reason for calculating concept_count nor term_count in a separate script. These two numbers should be calculated by Jekyll-Geolexica, similarly to how language statistics (displayed on Statistics page) are calculated: https://github.com/geolexica/geolexica-server/blob/35e2b9a1bc4f27e06634be8fc7430e28495512dc/lib/jekyll/geolexica/glossary.rb#L61-L70.
Correct, we can calculate these if possible.
Glossary version cannot be calculated. It should be kept somewhere in geolexica/isotc211-glossary. Alternatively, it should be set in site config.
Yes, we need to find a place to keep it. It should be kept in isotc211-glossary.
Okay, let's do it this way:
concept_count
— total number of concepts, should be obtained from Jekyll-Geolexicaterm_count
— total number of localized concepts, should be obtained from Jekyll-Geolexicaversion
— cannot be obtained from Jekyll-Geolexica. Let's move it to glossary/version.yaml
or integrate into glossary/tc211-termbase.meta.yaml
. Is the glossary/tc211-termbase.meta.yaml
good place for that? Will it break something? CC @strogonoff version — cannot be obtained from Jekyll-Geolexica. Let's move it to glossary/version.yaml or integrate into glossary/tc211-termbase.meta.yaml. Is the glossary/tc211-termbase.meta.yaml good place for that? Will it break something?
Glossarist doesn't yet support editing tc211-termbase.meta.yaml , but it can be edited manually. Won't break anything, let's proceed. Thanks!
scripts/generate_metadata.rb
produces YAML like this one:These are used on About page:
I see no reason for calculating
concept_count
norterm_count
in a separate script. These two numbers should be calculated by Jekyll-Geolexica, similarly to how language statistics (displayed on Statistics page) are calculated: https://github.com/geolexica/geolexica-server/blob/35e2b9a1bc4f27e06634be8fc7430e28495512dc/lib/jekyll/geolexica/glossary.rb#L61-L70.Glossary version cannot be calculated. It should be kept somewhere in geolexica/isotc211-glossary. Alternatively, it should be set in site config.