geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

clear button for search field #162

Closed ReesePlews closed 2 years ago

ReesePlews commented 2 years ago

after typing in a successful search term on geolexica, it is not possible to easily clear the previous search term without selecting and deleting or backspacing to remove the term. a small button to clear the previous term would be helpful. thank you

ronaldtse commented 2 years ago

Thanks @ReesePlews for the report.

@strogonoff would you or @yablokov have time for this? Thanks.

ronaldtse commented 2 years ago

image

We can add a "clear" (probably in the "X" shape) button to the search field to allow clearing a text

This code is here: https://github.com/geolexica/geolexica-server/blob/ca6cd49b5a56a281951b8cc096d356300fa42313/assets/js/concept-search.js#L215

ronaldtse commented 2 years ago

Thanks @strogonoff !

strogonoff commented 2 years ago

This is implemented in principle. However, it is required to go through multiple gem releases (jekyll-geolexica, geolexica-site), and to reduce that overhead this change may be combined with other changes in the gem into one release, so it may take a few hours before this change makes its way to production site.

On 30 Nov 2021, at 3:32 PM, Ronald Tse @.***> wrote:

 Assigned #162 to @strogonoff.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or unsubscribe.

ReesePlews commented 2 years ago

hello @strogonoff thank you for working on this. i am not sure where the small "X" will be placed, is it possible to move it to the left of the input box? in the above image i am not sure if the position, next to "Find a concept" is clear. but if it requires more time, then there is no hurry today. thank you

ronaldtse commented 2 years ago

Works but missing the "x" sign still?

Screenshot 2021-12-01 at 9 12 13 PM
strogonoff commented 2 years ago

fixed, button now has an icon.

ronaldtse commented 2 years ago

Thanks @strogonoff !