search

geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

modification of English entry display in geolexica #163

Closed ReesePlews closed 2 years ago

ReesePlews commented 2 years ago

I have detailed the issue and proposed revisions to help improve the understanding of the English entries displayed in Geolexica. These details are provided in the image

geolexica_english_entry_display_revision_request_20211103_r02 . There are no changes to the display of the other entries.

ronaldtse commented 2 years ago

In this task, we need to update the location of the "source" field on top. (Move it next to Term ID)

image

The HTML code is here: https://github.com/geolexica/geolexica-server/blob/ca6cd49b5a56a281951b8cc096d356300fa42313/_includes/concepts-list.html

ronaldtse commented 2 years ago

Thanks @strogonoff !

strogonoff commented 2 years ago

Issues like this seem to belong to geolexica-server repository, which handles entry display and such.

On 30 Nov 2021, at 3:32 PM, Ronald Tse @.***> wrote:

 Thanks @strogonoff !

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or unsubscribe.

ronaldtse commented 2 years ago

Correct, I've already posted the link to the relevant code. I assume that this can be done via pure CSS.

ronaldtse commented 2 years ago

And the change only applies to the desktop layout, the mobile layout does not require this change.

ronaldtse commented 2 years ago

Still being fixed!

strogonoff commented 2 years ago

Changes: https://github.com/geolexica/geolexica-server/commit/04923439d4db0112f43cc59e8c65545294ac38ca https://github.com/geolexica/geolexica-server/commit/c6f6b3d66d243813355911f6c78ee3f98df4ee67 should address this, confirming…

strogonoff commented 2 years ago

Partially done, where to get the new link text format for bottom SOURCE needs to be confirmed:

Screenshot 2021-12-01 at 2 26 17 PM
ronaldtse commented 2 years ago

Thank you @strogonoff !

ReesePlews commented 2 years ago

@strogonoff thank you very much for doing the enhancement. i think it may not have been mentioned but for the "source" reference in the ENG entry i was intending the source reference be surrounded by [ ] like the regular source reference is inside of a clause 3 entry. when i discussed this with @ronaldtse i should have added that to the text description in the image i made. the [ ] are shown at 2 in the original image. if they can be added as shown for only the english entry and only at 2 that would be very helpful. there is no change to 1, it has been formatted correctly. please let me know if you have any questions. thank you

ReesePlews commented 2 years ago

@strogonoff i confirm the [ ] have been added to the ENG entry source reference as requested. thank you. i will close this issue.