geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

"Copy" term definition functionality works in Safari but not Firefox #171

Closed ronaldtse closed 2 years ago

ronaldtse commented 2 years ago

From @reeseplews:

Anton, thank you for adding this functionality. i tried it in FFox but it does not paste the text. the copy buffer appears to be full but nothing is pasted to another window/app. there is no problem using MS-Edge.

Originally posted by @ReesePlews in https://github.com/geolexica/isotc211.geolexica.org/issues/164#issuecomment-985958728

ronaldtse commented 2 years ago

I can verify that I encountered the same problem here: https://isotc211.geolexica.org/concepts/2236/

In Firefox nothing gets copied for some reason.

strogonoff commented 2 years ago

It should work in Firefox now and is accessible (can focus with keyboard, etc.).

Additionally, original math markup is now replaced with <<math_symbol>>.

@yablokov’s commit https://github.com/geolexica/geolexica-server/commit/8258738ca792545e2d7854280efe67d961e657b3

ReesePlews commented 2 years ago

update edit 2: i tried again and perhaps there is some issue to clear the cache. in private ffox window the rendering is correct. i will close this issue. thank you.

thank you @strogonoff i can confirm the copy/paste functionality is working in firefox now, however there is a slight difference in the rendering, as shown in the image. geolexica_copy-paste_button in Firefox the "copy icon (two offset overlapping rectangles) is not shown and only a "copy" with underline is shown. also the "copy" with underline is not an active link. when you mouse over nothing changes. if you press "copy" it will copy and the paste into a text window is correct, but the render between the two pages is not matching. please check when you have time. thank you.

update edit 1: regarding the copy of the math characters/symbols. i have not examined them. i knew they would be a bit of a problem. i will check them later. the copy/paste functionality, in my thinking, was to be used by editors to copy the terms out of geolexica and paste into word, where they would then be assigned the correct style. this implemented function will help greatly i believe. thank you

ReesePlews commented 2 years ago

@strogonoff i tried again and perhaps there is some issue to clear the cache. in private ffox window the rendering is correct. i will close this issue. thank you.