geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

"browse all" concepts list is not showing <domains>, but "search results" do; staging site dropping last translated lang from search results #210

Open ReesePlews opened 2 months ago

ReesePlews commented 2 months ago

when doing a "browse all concepts" on both the deployed and staging versions i am noticing that the \<domains> are not showing.

left (staging site); right (deployed site)

image

when doing an actual search, the domains do show but there are is another issue like the last translated language is being removed from the staging site.

left (staging site); right (deployed site)

image

i would expect the concept list to show the \<domains> however since both do not, then maybe it never did, not sure. in that case adding the \<domain> after the concept would kind of be an "enhancement". the issue with one translation not showing up on the staging site seems like a problem.

if working on the staging site is too difficult (i thought it was just a copy) perhaps we need to update on the main site and take it down for a couple of days while that update takes place? @HassanAkbar please discuss this with @ronaldtse ; i dont want to make extra work for you.

ronaldtse commented 2 months ago

Thanks @ReesePlews for the report. @HassanAkbar could you please help? Thanks.

HassanAkbar commented 2 months ago

the issue with one translation not showing up on the staging site seems like a problem.

@ronaldtse the issue is that the language codes have been changed, previously the language code for German was deu and now it is ger. As we are only showing the languages mentioned in the config the ger language is being skipped because it is not present in the list of languages that we need to show.

Do we need to add ger to the language list or do we need to use deu as the language code?

ronaldtse commented 2 months ago

“ger” is the ISO 639-2 code for German but incorrect usage. In any case we should still support it, can you help?

@strogonoff please use “deu” instead of “ger” for terminology:

strogonoff commented 2 months ago

@ronaldtse we haven’t been using ger for years, only deu is used.

strogonoff commented 2 months ago

@ronaldtse Perhaps you meant to ping @HassanAkbar in your comment?

strogonoff commented 2 months ago

We use a workaround for French, where we support both fre and fra as stopgap measure just to prevent things from breaking. It’s not a good idea, but we could do the same for German.

By “we” I mean Paneron & Glossarist extension.

HassanAkbar commented 2 months ago

“ger” is the ISO 639-2 code for German but incorrect usage. In any case we should still support it, can you help?

Thanks @strogonoff . Your insight about French language is helpful.

@ronaldtse Sure, also the language code for Chinese is changed to chi from zho. I’ll update the config file to also include both ger and chi in the list.

Should I also update the isotc211-glossary to use deu and zho instead of ger and chi? Or We can also update the isotc211-termbase code to map these to the correct values. What do you suggest?

UPDATE:

The reason behind this questions is that I just want to understand that is there any other way that the data can be produced? if yes then I think updating the config is a better option otherwise I think adding mapping in isotc211-termbase is a better option.

ronaldtse commented 2 months ago

This error actually comes from the Excel file:

Screenshot 2024-04-24 at 9 48 19 AM Screenshot 2024-04-24 at 9 48 36 AM

@HassanAkbar please help update this in the isotc211-termbase gem. It's time we fix this error.

@ReesePlews hope this is okay with you.

ReesePlews commented 2 months ago

thanks @HassanAkbar and @ronaldtse for looking into these issues. i thought there would be no change to the register content from https://isotc211.geolexica.org/registers/

if there needs to be changes in the excel sheet, tell me where to check and i will update the sheet so we do not have this issue again. i think we should follow any prescribed ISO standards in this matter. my spreadsheet can easily be updated and in the future we are not going to have the sub-registers any more.

more than happy to follow your lead on this. thank you

ronaldtse commented 2 months ago

@ReesePlews the error is in the excel file. According to ISO 639-2, the chi and ger codes are not to be used for “terminology”, but can be used for “bibliography”. This differentiation is due to when 639-2 was first established they used English to make the codes, but they corrected them afterwards to use the native spelling (in Latin alphabets). That’s why the “T” codes are in native spelling but “B” codes accept English spelling.

Since MLGT is a terminology set, it should use the “T” codes.

ronaldtse commented 2 months ago

@ReesePlews we can change it in code for now.

ReesePlews commented 2 months ago

@ronaldtse thank you for making those changes. the MLGT is over 15 years old, and perhaps those rules/specifications were not established at that time, or they are just a mistake. after i find the correct codes in the "registers" page, i will update the spreadsheet. i am not sure if you are still using the staging site for these modifications. if it is the staging site, then they will automatically update. if you need to update the registers page just do it as simple as possible, modifying the deployed site for that update would not be a problem, please confirm which way Hassan should do. thanks for getting this fixed the best way!

ronaldtse commented 2 months ago

@ronaldtse we haven’t been using ger for years, only deu is used.

Thanks @strogonoff for the confirmation!

ronaldtse commented 2 months ago

Fixed here:

Released in tc211-termbase 0.2.6.

ronaldtse commented 2 months ago

@HassanAkbar can you please help update the language codes in the output data set using the newly released gem? Thanks.

ronaldtse commented 2 months ago

@HassanAkbar if this is fixed please help close this. Thanks.

ReesePlews commented 2 months ago

i am seeing an something strange, let me describe in a new issue

ReesePlews commented 2 months ago

additionally, on both the staging site:

image

and the deployed site:

image

i am noticing that not all of the translations are showing.

how difficult would it be to show all of the translated languages in these views? in this example there are 9 translated languages.

ReesePlews commented 2 months ago

@HassanAkbar i see the now added to the list, thank you. however the number of translations is still off or missing...

image

HassanAkbar commented 2 months ago

@ReesePlews I'm looking into it. I will let you know once the issue is resolved.

HassanAkbar commented 2 months ago

@ReesePlews I just looked into it and this is happening because when we search for a concept it shows only the translations that matches with the search term.

For example if we search for kerrannaisuus which is fin translation for multiplicity it only shows that translation.

Screenshot 2024-04-25 at 7 22 07 PM

@ronaldtse is this the expected behavior or do we need to show all the translations?

ReesePlews commented 2 months ago

@HassanAkbar thank you for discovering the reason for this behavior. i will need to think about this because it very well could be expected behavior. let me think on this a while and i will get back to you and @ronaldtse in a day or two. thank you, for now please wait.

HassanAkbar commented 2 months ago

@HassanAkbar thank you for discovering the reason for this behavior. i will need to think about this because it very well could be expected behavior. let me think on this a while and i will get back to you and @ronaldtse in a day or two. thank you, for now please wait.

Thanks @ReesePlews . Sounds good, take your time.

ReesePlews commented 1 month ago

hello @HassanAkbar i would like to make the release of the new data you have added to geolexica next week. do you think that is possible?

can you tell me the status on this and if there have been any changes to the staging area url.

i think we were talking about the number of translations that came up when typing an english term into the search box... and i believe we determined this was the expected behavior of the site.

is there anything else we need to discuss before the release? i can only think of a blog post on the site about the release. lets ask @ronaldtse if he has anything else outstanding at this time or wants to discuss.

based on that reply and your schedule, please pick an appropriate date for the release next week and we can follow up from there. thank you.

HassanAkbar commented 1 month ago

@ReesePlews I can't think of anything right now but I will still check if there is some pending discussions.

I'll wait for @ronaldtse reply to pick a date for the release.

ReesePlews commented 3 weeks ago

hello @ronaldtse, just wondering if @HassanAkbar can make the release this week? i would like the updated MLGT contents on geolexica to be active before the TMG meeting on June 26th. would this be possible, or are there some issues still under consideration? please let me know, happy to discuss anything. thanks.

HassanAkbar commented 3 weeks ago

@ReesePlews The concepts are now live on production at https://isotc211.geolexica.org

cc: @ronaldtse

ReesePlews commented 3 weeks ago

thank you @HassanAkbar and @ronaldtse ! thats great. will we keep the staging site there or will it be deleted? no one knows the url, so i am ok if you keep it for the next update. really appreciate all of the you and the team have done with this update. thanks!