search

geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

Broken front page news widget with smaller viewport #74

Closed ronaldtse closed 5 years ago

ronaldtse commented 5 years ago

A picture is worth a thousand words...

image
strogonoff commented 5 years ago

Could you clarify the issue? Is it the lack of obvious horizontal scrolling affordances?

On 11 Aug 2019, at 11:33 AM, Ronald Tse notifications@github.com wrote:

Assigned #74 to @strogonoff.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.

strogonoff commented 5 years ago

Oh I see image now

strogonoff commented 5 years ago

Could you clarify browser/OS @ronaldtse? Unreproducible under Safari/iOS.

ronaldtse commented 5 years ago

macOS Safari. The scroll bar should not appear, the news item boxes should flow to the bottom. There's also a large vertical empty space between the footer and the news item boxes.

Thanks!

strogonoff commented 5 years ago

Strange, will look into the broken layout issue if I can reproduce it on macOS Safari.

The intention has been for it to be horizontally scrolled, redesign of news block behavior can be done next if there is a particular issue with the design after the layout bug is fixed.

On 11 Aug 2019, at 5:07 PM, Ronald Tse notifications@github.com wrote:

macOS Safari. The scroll bar should not appear, the news item boxes should flow to the bottom. There's also a large vertical empty space between the footer and the news item boxes.

Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ronaldtse commented 5 years ago

We just want the news items to be tiled rather than horizontal scrolling. Thanks

strogonoff commented 5 years ago

Indeed, this seems to be working as intended. What looked wrong to me is caused by the vertical spacing in layout, intentional but probably unnecessary (https://github.com/ISO-TC211/jekyll-theme-isotc211/issues/5). For news block layout redesign there is now https://github.com/ISO-TC211/jekyll-theme-isotc211/issues/4.