search

geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

Is DB versioned or generated during build? #83

Closed strogonoff closed 5 years ago

strogonoff commented 5 years ago

The build process seems to take care of this directory, so it’s unclear why it is under version control: https://github.com/ISO-TC211/geolexica.org/tree/master/db/iso

ronaldtse commented 5 years ago

@strogonoff this directory is the Relaton cache. It is generated but the cache makes the build faster.

strogonoff commented 5 years ago

Source version control isn’t really appropriate for caching purposes, I’d prefer that this was stored on S3 for example.

On 18 Aug 2019, at 1:22 AM, Ronald Tse notifications@github.com wrote:

@strogonoff this directory is the Relaton cache. It is generated but the cache makes the build faster.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

ronaldtse commented 5 years ago

@strogonoff technically this cache can be placed on Travis, perhaps you have an easy way of setting it up. We won't put it on S3 because it will mean prior to build a pull from S3 has to happen.

ronaldtse commented 5 years ago

There are legitimate uses of committing cache to source control too, for example automake and CMake files. I do agree with keeping source clean, but sometimes it's a compromise between environment restrictions and ease of execution...

ronaldtse commented 5 years ago

Moved to new task.

strogonoff commented 5 years ago

@ronaldtse

There are legitimate uses of committing cache to source control too, for example automake and CMake

That’s OK, but auto-generated things that we can expect to be changing will pollute commit history. I don’t think automake falls under that category.