search

geolexica / isotc211.geolexica.org

ISO/TC 211 online version of the Multi-Lingual Glossary of Terms
https://isotc211.geolexica.org
4 stars 2 forks source link

CI (-only?) build failure during concept population after switching to geolexica-database #92

Closed strogonoff closed 4 years ago

strogonoff commented 4 years ago

Current Makefile appears to work on macOS, but gives the following on GHA CI during the step where concepts from geolexica-database are used to populate the _concepts Jekyll collection:

Screenshot 2019-12-04 at 8 33 12 AM
strogonoff commented 4 years ago

Here’s where this bug was introduced (while fixing another bug) by me: https://github.com/ISO-TC211/geolexica.org/commit/6ad74646a526dfd1608a611d84a4be10feedc0bf

The new approach is to not generate concepts through an intermediate Makefile target anymore. Instead, already built concepts from submodule geolexica-database are copied over and processed. That logic seems faulty.

cc @ronaldtse I’m not sure what’s going on there, perhaps my Makefile/shell scripting kung fu isn’t enough…

ronaldtse commented 4 years ago

Fixed in 12a0d9b