search

geoman-io / leaflet-geoman

🍂🗺️ The most powerful leaflet plugin for drawing and editing geometry layers
https://geoman.io
MIT License
2.21k stars 433 forks source link

Some icons broken after updating from 2.13.0 -> 2.16.0 #1511

Open viktorsmari opened 1 month ago

viktorsmari commented 1 month ago

image

Here we have some icons (not all) broken after this update.

When inspecting we see some don't work image

Some work image

When I open up a broken icon in a new tab it actually works: image

Could the %0A be a part of the issue? image

Any ideas how I could debug further?

viktorsmari commented 1 month ago

If I use a CDN it works, so I cannot reproduce on JSFiddle.

I am using Ruby on Rails and esbuild.

package.json:

  "dependencies": {
    "@geoman-io/leaflet-geoman-free": "^2.16.0",

app/assets/stylesheets/application.bootstrap.scss:

@import 'leaflet.markercluster/dist/MarkerCluster.Default';
@import 'flatpickr/dist/flatpickr';
@import '@geoman-io/leaflet-geoman-free/dist/leaflet-geoman';

This works fine in earlier versions:

Falke-Design commented 1 month ago

Hi, with the 2.16.0 Version we accidentally made a breaking change. The build process was updated and sometimes causes problems with older builders. We suggest to try to update your builder.

See: https://github.com/geoman-io/leaflet-geoman/releases/tag/v2.16.0

viktorsmari commented 1 month ago

Thanks @Falke-Design I am using version 0.23.1 of esbuild - but still having this issue. What else should I upgrade?