geoman1217
commented
6 years ago Thank you for the review.
Open karl-project-review opened 6 years ago
geoman1217
commented
6 years ago Thank you for the review.
(Meets Expectations)
Good work with this project!
Your code performed all the necessary computations and (with the exception of a rounding error with the sample size calculator input noted in another issue) you calculated the proper results. Also, your charts display everything they should and are appropriately labeled. Since your code functions properly, I would encourage you to start to focus on its form by referring to the Python style guide (https://www.python.org/dev/peps/pep-0008/). Adding in comments when appropriate and breaking up lines can help ensure your code is easy to follow and work with.
Your project clearly conveys the process you went went through and the results of your calculations. It also uses graphics effectively to supplement the written text. However, including an interpretation of what the significance test results mean in practical terms would be very helpful for your audience. What does it mean if the difference is significant? What should we take away from that? I'd encourage you to think about those questions and try to clearly explain your answers to them.
Again, nice job with this!