search

geomarker-io / cincy

Cincinnati Neighborhood, Tract, County, and ZIP Code Geographies
https://geomarker.io/cincy/
GNU General Public License v3.0
0 stars 0 forks source link

create crosswalks; save as internal data #6

Closed erikarasnick closed 2 years ago

erikarasnick commented 2 years ago

The way it is currently written, we would have to use the triple colon to access the crosswalk datasets. I think we had discussed keeping them internal data here, then using them in exported functions in CODECtools. I'm starting to think the crosswalks and the crosswalk functions should be in the same package... what do you think? Then the example of how to use the crosswalks would go in whichever package that is. It seems weird to me to keep the crosswalks here, write the crosswalk functions in CODECtools, and show their example use here.

cole-brokamp commented 2 years ago

When I install from this branch, I can only see the following in the ::: namespace:

image

and I see this when trying to access them:

r$> cincy::tract_to_zcta_2020
Error: 'tract_to_zcta_2020' is not an exported object from 'namespace:cincy'

r$> cincy:::tract_to_zcta_2020
Error: object 'tract_to_zcta_2020' not found
cole-brokamp commented 2 years ago

But, I agree on making the functions and weights in the same package. Let's keep working on this through this PR and then talk more tomorrow about where it should live long-term.

erikarasnick commented 2 years ago

I know I ran the code for all the crosswalks, but somehow they didn't actually get stored in sysdata.rda. Now they should be accessible with the triple colon.