search

geomatsi / ftdi-embedded-hal-archive

Check https://github.com/ftdi-rs project for the up-to-date implementation of FTDI MPSSE embedded HAL.
MIT License
31 stars 6 forks source link

Add MIT license to project. #8

Closed brandonedens closed 3 years ago

brandonedens commented 3 years ago

crates.io specifies the project is licensed MIT but no license exists in the Github repository. Add the MIT license taken from the rust lang project to the repository.

geomatsi commented 3 years ago

Hi @brandonedens

This project has never been published on crates.io. You may have confused this repo with another one named ftd2xx-embedded-hal. On the other hand, MIT looks reasonable. Let me take a look at the dependencies (ftdi-rs and libftdi) and check if their licenses do not prohibit this choice.

Regards, Sergey

eldruin commented 3 years ago

Hi Sergey! The licenses of the dependencies should not be a problem for this project itself. The terms do not apply transitively. Any reason why this should not be published on crates.io besides the need to publish ftdi-rs as well?

geomatsi commented 3 years ago

Hi Diego,

Well, my changes to ftdi-rs have not been accepted. IIRC the author planned some significant changes, but that work stalled a while ago. I think I need to take a look at the current project state and probably do another attempt to submit my changes. On the other hand ftd2xx-embedded-hal has been released, so probably it makes sense to contribute to that project instead.

Regards, Sergey

eldruin commented 3 years ago

Ah, I see. Thank you for the insight. :)