search

geometer / FBReaderJ

Official FBReaderJ project repository
http://www.fbreader.org/FBReaderJ/
1.83k stars 802 forks source link

empty-line tag is not displayed properly #465

Closed link2xt closed 6 years ago

link2xt commented 6 years ago 
<?xml version="1.0" encoding="UTF-8"?>
<FictionBook xmlns="http://www.gribuser.ru/xml/fictionbook/2.0" xmlns:l="http://www.w3.org/1999/xlink">
<body>
    <title><p>title</p></title>
    <section><p>abc<empty-line />def</p></section>
</body>
</FictionBook>

FBReader on Android displays "abc" only, Linux version does not display anything but title. Cool Reader displays document correctly.

geometer commented 6 years ago

Good point, thanks. The parser did not expect empty-line tag inside a paragraph. Fixed in FBReader for Android 2.8.5/for iOS 1.0.2. Sorry, it is not open-source at the moment.

yuriifabirovskyi commented 6 years ago

Why it is not open source?

geometer commented 6 years ago

Unfair use of GPL code became common practice last years.

dbdean commented 6 years ago

This is unfortunate, but good to see it has been acknowledged by the author. I started using fbreader over moon+reader because it was open source.

It looks like someone is maintaining a recent fork at https://github.com/benetech/FBReaderJ as GoRead: http://goread.org/, and CoolReader might also be an alternative for people who want an open-source ereader: https://sourceforge.net/projects/crengine/, https://play.google.com/store/apps/details?id=org.coolreader&hl=en.

yuriifabirovskyi commented 6 years ago

@dbdean Thanks. I will try Go Read.:)