geometric-kernels / GeometricKernels

Geometric kernels on manifolds, meshes and graphs
https://geometric-kernels.github.io/
Apache License 2.0
214 stars 18 forks source link

Weird documentation in EigenfunctionsWithAdditionTheorem #54

Closed stoprightthere closed 1 year ago

stoprightthere commented 2 years ago

In https://github.com/GPflow/GeometricKernels/blob/8d8c9c5ac08be9b3e87a1144539835bbf87fd779/geometric_kernels/spaces/eigenfunctions.py#L115 it says it expects weights size of [L, 1] but that doesn't seem true -- we specifically make weights be [M, 1] where M is the total number of eigenvalues?