geometric-kernels / GeometricKernels

Geometric kernels on manifolds, meshes and graphs
https://geometric-kernels.github.io/
Apache License 2.0
214 stars 18 forks source link

Bug in Gaussian process on mesh using GPflow #93

Closed BinglinW closed 1 year ago

BinglinW commented 1 year ago

There is a wrong when running the demo: Gaussian process on mesh using GPflow

base_kernel = MaternKarhunenLoeveKernel(mesh, nu, truncation_level)

TypeError: init() takes 3 positional arguments but 4 were given

stoprightthere commented 1 year ago

Hi @BinglinW , thank you for opening the issue!

The cause of the error is that MaternKarhunenLoeveKernel does not take nu as an argument now (it did in the early version, and we forgot to update the demo accordingly). The following should work: base_kernel = MaternKarhunenLoeveKernel(mesh, truncation_level)

We will update the demo soon to reflect the change.

Thanks!

BinglinW commented 1 year ago

Hi @BinglinW , thank you for opening the issue!

The cause of the error is that MaternKarhunenLoeveKernel does not take nu as an argument now (it did in the early version, and we forgot to update the demo accordingly). The following should work: base_kernel = MaternKarhunenLoeveKernel(mesh, truncation_level)

We will update the demo soon to reflect the change.

Thanks!

Thanks for your help!