geometricpanda / storybook-addon-badges

An addon for Storybook which allows the addition of badges to your Stories
https://geometricpanda.github.io/storybook-addon-badges/
MIT License
9 stars 7 forks source link

Storybook v7 #11

Closed Sephyr0s closed 1 year ago

Sephyr0s commented 1 year ago

Hi,

Thanks for all the work developing this plugin.

at my place we decided to already upgrade to Storybook v7 due to better Vue support. We're wondering if there are already plans here to make the plugin ready for Storybook 7. Considering it's already on release candidates I doubt there will be any big changes.

From the migrations notes

https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#70-core-addons-changes https://github.com/storybookjs/storybook/blob/next/MIGRATION.md#70-addon-authors-changes

geometricpanda commented 1 year ago

Hey, I'm super open to making this Storybook 7 safe, i'll see what I can do over the bank holiday weekend

geometricpanda commented 1 year ago

Hey folks, i've pushed a canary release 2.0.0--canary.12.aa9de47.0

You can install this using

npm install @geometricpanda/storybook-addon-badges@2.0.0--canary.12.aa9de47.0

or

yarn add @geometricpanda/storybook-addon-badges@2.0.0--canary.12.aa9de47.0

Could I trouble you to test in your environments please? Once I've had a few folks say they're happy with it then i'll cut 2.0.0

It's not really a breaking change, but thought best to mark it as due to the Storybook Preview pattern changing.

Tested in

Notes When testing Angular, I got some warnings about prettier & react-textarea-autosize, I'm assuming this is Storybook 7 Angular issue as I dont use either of them in the distribution.

tommiv commented 1 year ago

@geometricpanda Canary release compiles without warnings && works as intended in SB v7.0.2 with Vue v2:

image

Sephyr0s commented 1 year ago

Works like a charm! Question though, since in Storybook 7 they seperated docs and canvas different, is it possible to show the badges on the docs page? Or do I need to make a new enhancement request for this?

Thanks for the good work!

image
geometricpanda commented 1 year ago

@Sephyr0s Yeah i noticed that, i'll keep looking into it, but thanks to you and @tommiv for testing - i'll release 2.0.0 now