Storybook 8 compatibility

joevaugh4n commented 6 months ago

Hey @geometricpanda! I’m reaching out from the core SB team :)

Storybook 8 (our next major release) is coming soon, and it introduces some breaking changes that your addon might need to account for.

We’ve listed all the key changes in a new Storybook 8 migration guide, and we’d encourage you to check it out and see if your addon is impacted.

We also have an addons channel in our Discord community, which we’d like to use to better communicate with addon authors in the future. If you’re not part of the server, consider joining here and message me (@joevaugh4n) so that I can give you the addon creator role! If you’re already in the server, please just ping me and I’ll respond to you there.

Thanks for being a part of our addon community!

Joe

JamesIves commented 5 months ago

Just attempted a version 8 upgrade, and I'm seeing this error flagged by storybook-addon-badges:

❯ npx storybook@latest doctor
🩺 The doctor is checking the health of your Storybook..
╭ Incompatible packages found ───────────────────────────────────────────────────────────────────────────────────────────────────────╮
│                                                                                                                                    │
│   The following packages are incompatible with Storybook 8.0.0 as they depend on different major versions of Storybook packages:   │                                                   │
│   - @geometricpanda/storybook-addon-badges@2.0.2                                                                                   │                                                                              │                                                                                             │
│                                                                                                                                    │
│                                                                                                                                    │
│   Please consider updating your packages or contacting the maintainers for compatibility details.                                  │
│   For more on Storybook 8 compatibility, see the linked GitHub issue:                                                              │
│   https://github.com/storybookjs/storybook/issues/26031                                                                            │
│                                                                                                                                    │
╰────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────╯

carlwelchyubico commented 5 months ago

I'm able to successfully display Badges, But I see this error when starting up 8.04

15% building 0/2 entries 62/161 dependencies 4/42 modulesWARN Failed to parse .storybook/preview.ts with react-docgen. Please use the below error message and the content of the file which causes the error to report the issue to the maintainers of react-docgen. https://github.com/reactjs/react-docgen
SyntaxError: ./.storybook/preview.ts: Unexpected token, expected "}" (37:18)

  35 |     },
  36 |     badgesConfig: <BadgesConfig>{
> 37 |       [BADGE.BETA]: {
     |                   ^
  38 |         styles: {
  39 |           backgroundColor: '#FFF',
  40 |           borderColor: '#018786',

math-bourgeois commented 4 months ago

Do we know when a new release will be created to include this fix?

Freytag commented 4 months ago

I pulled down the latest code and noticed that this should be resolved with whats on main, looks like we're just waiting for a successful release to happen.