search

geometricpanda / storybook-addon-badges

An addon for Storybook which allows the addition of badges to your Stories
https://geometricpanda.github.io/storybook-addon-badges/
MIT License
9 stars 7 forks source link

Storybook 8 compatibility #22

Closed evg4b closed 5 months ago

evg4b commented 5 months ago

Hi @geometricpanda, I have updated dependencies to support Storybook 8 (see issue #20). Also, all deps were updated to the latest versions.

geometricpanda commented 5 months ago

Ooh awesome. I'll review this later today

I've been talking with Storyblok about some changes to better work with Storyblok 8, but this also sounds great.

bberto commented 5 months ago

Hello @geometricpanda, any update on this? Thanks for this useful addon, and thanks @evg4b for the contribution!

geometricpanda commented 5 months ago

Hey, I've just merged

alexpthomasdev commented 5 months ago

Hi @geometricpanda Thanks for merging! Seems like it was an error on the package creating and the npm package wasn't release

geometricpanda commented 5 months ago

I saw, it's on my todo list for today

JamesIves commented 5 months ago

Any updates on that version? 👀

JamesIves commented 4 months ago

@geometricpanda I've pushed up a PR that should hopefully resolve the publication workflow: https://github.com/geometricpanda/storybook-addon-badges/pull/23

geometricpanda commented 4 months ago

Awesome thanks,

JamesIves commented 4 months ago

Not sure why that didn't publish. Tried to debug it more in my fork but it works every time I push to the main branch.

Possible issue with the NPM_TOKEN perhaps? Or maybe you need to re-run the workflow so it's not executed from a user besides yourself by making a minor change to the base branch?