search

geometry-zsh / geometry

geometry is a minimal, fully customizable and composable zsh prompt theme
ISC License
920 stars 94 forks source link

Replace source by . #171

Closed zapashcanon closed 6 years ago

zapashcanon commented 7 years ago

It doesn't make a difference with zsh, but . is POSIX and source is not. So it may be better to tell people to use . as they'll learn something that is portable.

frm commented 7 years ago

Would this make in difference since source is used throughout the project?

desyncr commented 7 years ago

We'd have to update the wiki pages as well.

zapashcanon commented 7 years ago

I can do it if you agree that it's a good change.

desyncr commented 7 years ago

I have no strong opinions about it. If nobody is against it let go for it. @fribmendes @jedahan

frm commented 7 years ago

I don't oppose, as long as we define a convention and stick to it 😛

jedahan commented 7 years ago

If geometry's goal was to be portable across non-zsh shells, I would be for it, but there are many other places that use zsh-specific stuff that would make that goal tricky. In addition, source is easier to read, and fix if misspelled than . for newcomers. Though I am glad that people are considering portability, I'm a weak 'no' on this change for the previous reasons.

desyncr commented 6 years ago

I do agree with @jedahan.

@zapashcanon Thanks for contributing anyways!