geometry-zsh / geometry

geometry is a minimal, fully customizable and composable zsh prompt theme
ISC License
931 stars 94 forks source link

Git plugin not working #210

Closed danielftapiar closed 6 years ago

danielftapiar commented 6 years ago

I cant seem to get the git plugin to work, it seems to work randomly Any tips?

deepinscreenshot_select-area_20180508230147

frm commented 6 years ago

What's your OS, version and zsh version?

danielftapiar commented 6 years ago

Running Deepin OS 15.5 (Debian Based) zsh 5.3.1 (x86_64-debian-linux-gnu)

jedahan commented 6 years ago

Can you post the most minimal zshrc that reproduces this behaviour?

danielftapiar commented 6 years ago

export ZSH=$HOME/.oh-my-zsh PROMPT_GEOMETRY_COLORIZE_ROOT=true PROMPT_GEOMETRY_EXEC_TIME=true PROMPT_GEOMETRY_COLORIZE_SYMBOL=true GEOMETRY_SYMBOL_EXIT_VALUE="⚠️ " GEOMETRY_COLOR_DIR="blue" GEOMETRY_PROMPT_SUFFIX=" → " GEOMETRY_SYMBOL_GIT_CLEAN="✔︎" GEOMETRY_SYMBOL_GIT_DIRTY="⚡️" GEOMETRY_SYMBOL_GIT_UNPULLED="↓" GEOMETRY_SYMBOL_GIT_UNPUSHED="↑" GEOMETRY_SYMBOL_GIT_CONFLICTS_SOLVED="💚" GEOMETRY_SYMBOL_GIT_CONFLICTS_UNSOLVED="💔" ZSH_THEME="geometry/geometry"

PROMPT_GEOMETRY_COLORIZE_SYMBOL=true

export BROWSER='/usr/bin/google-chrome' export EDITOR="vim" plugins=(z git zsh-autosuggestions colored-man-pages sublime ssh-agent laravel5 kubectl zsh-syntax-highlighting) source $ZSH/oh-my-zsh.sh

jedahan commented 6 years ago

Sorry I was not clear, can you post the smallest zshrc that still loads the theme and shows this error? For example, this ~/.zshrc-issue-210-snbsniper just loads the theme and nothing else

# ~/.zshrc-issue-210-snbsniper
source /Users/micro/.zr/plugins/geometry-zsh/geometry/geometry.plugin.zsh
fpath+=/Users/micro/.zr/plugins/geometry-zsh/geometry/
PATH=/Users/micro/.zr/plugins/geometry-zsh/geometry:$PATH

You can test it with

zsh --no-rcs --no-globalrcs --login -c "~/.zshrc-issue-210-snbsniper"

I bet what is happening is that oh-my-zsh has its own git plugins that are conflicting with ours.

jedahan commented 6 years ago

Also from a cursory search of ZSH_THEME="geometry/geometry" saw a decent number of people using the theme, maybe one of @csmets, @ryosukeminami, @HCastano, @oscarorti, or @apdaros could comment on if they get the same error, and if so, how we can help fix it.

jedahan commented 6 years ago

Specifically, https://github.com/apdaros/dotfiles/blob/master/.zshrc looks promising as a minimal working example

HCastano commented 6 years ago

I haven't had an issue with the Git plugin.

ZSH: zsh 5.2 (x86_64-apple-darwin16.0) I'm running Geometry at commit: ce55adfc3

frm commented 6 years ago

I can reproduce this when using pass in a git repo. I don't use oh-my-zsh. But it can also be conflicts with that.

apdaros commented 6 years ago

Also works fine for me, but I'm at c4e0ed60 which is pretty old

screen shot 2018-05-09 at 18 18 12

frm commented 6 years ago

I haven't been able to reproduce for a while now. Turns out on my end it was an issue with the pass config.

frm commented 6 years ago

@SNBSniper have you had any updates on this? If not, can you try explicitly setting GEOMETRY_PROMPT_PLUGINS_SECONDARY to (git)?

jedahan commented 6 years ago

@SNBSniper closing due to inactivity and I think you switched to pure according to the dotfiles. Feel free to reopen if its still an issue