Closed frm closed 6 years ago
One possible alternative would be to recommend users to use other alternatives for bold characters. %BX%f
would be equivalent and would allow us to use a substitution mechanism similar to the adam2
one I linked. It feels a bit better do that instead of this, which feels a bit hackish.
It would a matter of changing one line to
local symbol_width="${#${(S%%)prompt_symbol//(\%([KF1]|)\{*\}|\%[Bbkf])}}"
I think this refactor is generally better than our current state, both in that it helps a user, and is easier to read with the split up variables. We can revisit in the future but I am fine with this hack being merged sooner than later.
Here's a preview of the support:
When merging I'd rather squash and keep the first commit message, as it provides context for everything, when looking through the git log 😄
Ahh squash & merge makes sense. This looks good to me
Why:
GEOMETRY_SYMBOL_PROMPT="\e[1mX\e[0m"
, it would be expected that X was bold.This change addresses the need by:
Notes:
adam2
in this Stack Overflow question.