search

geometry-zsh / geometry

geometry is a minimal, fully customizable and composable zsh prompt theme
ISC License
921 stars 94 forks source link

Refactor geometry_git function #242

Closed jedahan closed 5 years ago

jedahan commented 5 years ago

Right now geometry_git is the most complex (and useful!) function we ship. However, it is clunky to customize, as seen in #226 .

Let's look at exposing all the inner functionality - _symbol, _branch, _status, _conflicts, _time, and _stashes, which would allow us to get rid of the clunky GEOMETRY_GIT_SHOW_{CONFLICTS,TIME,STASHES} vars, and reorder as the user sees fit.

We can also investigate the performance penalty of using zsh's builtin vcs_info for some of the prompt.

Of course, we can also just rebase #226 on top of mnml and see how that feels as well!

jedahan commented 5 years ago

fixed in https://github.com/jedahan/geometry/commit/5ec97e39400a3a0cd9f0bbed4796167b65a9eddd , will track performance vs vcs_info in another issue