search

geometry-zsh / geometry

geometry is a minimal, fully customizable and composable zsh prompt theme
ISC License
931 stars 94 forks source link

Holding enter crashes on macOS #289

Open jedahan opened 4 years ago

jedahan commented 4 years ago

From https://github.com/geometry-zsh/geometry/issues/286#issuecomment-569393966

jedahan commented 4 years ago

If I hold the ENTER key in git repository, it give zsh: error on TTY read: Input/output error and crash. OS X, zsh version 5.7.1

What version of OS X and what terminal? Can you post your entire ~/.zshrc and perhaps test with a more minimal version, like

# ~/.zshrc
test -d ~/.geometry || git clone https://github.com/geometry-zsh/geometry.git ~/.geometry
source ~/.geometry/geometry.zsh

Can you reproduce the issue with that setup? I'm having difficulty getting the same error.

jedahan commented 4 years ago

@j16sdiz I don't have a machine I can reproduce with, is this still an issue?

vyorkin commented 4 years ago

I'm using geometry v2.2.0. Looks like it is still an issue. I'm on NixOS 20.03, which is not FHS compliant (it that makes any difference). My terminal is Kitty v0.18.2. Geometry v2.1.0 has this issue as well with the same error message, but in Geometry v2.0.0 it shows up as:

geometry::rprompt:2: can't clobber parameter PCFD containing file descriptor 11

AFAI remember the previous version of geometry (v1.x.x) didn't have this issue.

Please note that I'm using a few other zsh plugins that might be the cause of a problem https://github.com/vyorkin/nixos-config/blob/master/home/zsh.nix#L36

And thank you for Geometry. I'm using it for the last couple of years and I'm very happy with it ;)

jedahan commented 4 years ago

can you post the output of setopt ?

it is possible someone else is using PCFD or the handle for it.

Is there a quick tutorial where i could reproduce your setup in a nice chroot or OCI image?

vyorkin commented 4 years ago 
alwaystoend
autocd
autopushd
nobeep
nobgnice
nocaseglob
cdablevars
chaselinks
noclobber
completealiases
completeinword
correct
extendedglob
globcomplete
globdots
nohistbeep
histexpiredupsfirst
histfcntllock
histignorealldups
histignoredups
histreduceblanks
histverify
nohup
incappendhistory
interactive
nolistbeep
monitor
nonomatch
pushdignoredups
pushdsilent
pushdtohome
sharehistory
shinstdin
zle
  1. What is PCDF?
  2. I don't have a fully reproducible repository, but here is my zsh-config files: https://github.com/vyorkin/zshrc + my set of plugins (there are commit hashes, so theoretically you should be able to reproduce my environment): https://github.com/vyorkin/nixos-config/blob/master/home/zsh.nix#L36

Please tell me if you need more info

jedahan commented 4 years ago

interesting - so PCFD we don't use anymore, maybe you are on an outdated geometry? version 2.0.3 we renamed PCFD to GEOMETRY_ASYNC_FD - its just the variable we use to help signal async stuff. Definitely could be a conflict with other projects.

vyorkin commented 4 years ago

I'm using geometry from this rev: d78d0daab3e16d19043fd225fe30bf38de3b33ad (v2.2.0) Yeah, I'll double-check everything and get back