Fix default value settings for select boxes

[theduckylittle]

Fix a long standing bug with boxes not properly setting their default values when an express default value was not set by the administrator.

refs: #776

chughes-lincoln commented 1 year ago

It looks like this may have introduced a bug with the select tool when layers aren't selectable (perhaps a bit more complicated than that as the OSM layer doesn't cause this issue). If you turn on those layers and open the drop-down for the select tool they show up as empty gaps in the drop-down.

It also has some odd interactions with the drawing and markup layer. Drawing and Markup now appears in the drop-down. If you add a sketch and then select by drawing and markup it seems to behave as if the sketch tools are active.

klassenjs commented 1 year ago

Can confirm what @chughes-lincoln said.

Turn on WX Radar, Go to Select Features, Click the Layers select box.

Also, with this change Drawing and Markup is now in the list. (I'm not sure this is necessarily a bad thing, but it is likely the result of an unintended side effect).

theduckylittle commented 1 year ago

I have a fix I’ll be pushing. I found the bug on the plane but haven’t been able to push it. 😂

On Thu, Jan 19, 2023 at 13:25 Jim Klassen @.***> wrote:

Can confirm what @chughes-lincoln https://github.com/chughes-lincoln said.

Turn on WX Radar, Go to Select Features, Click the Layers select box.

Also, with this change Drawing and Markup is now in the list. (I'm not sure this is necessarily a bad thing, but it is likely the result of an unintended side effect).

— Reply to this email directly, view it on GitHub https://github.com/geomoose/gm3/pull/786#issuecomment-1397553473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJZB43PSHT37HVBPN3AUJTWTGPKFANCNFSM6AAAAAATYD73L4 . You are receiving this because you authored the thread.Message ID: @.***>

theduckylittle commented 1 year ago

Added the bug fix and it's captured here. I rebased and squashed my commits so there's not a unique commit for it.

• © Githubissues.
• Githubissues is a development platform for aggregating issues.

[chughes-lincoln]

It looks like this may have introduced a bug with the select tool when layers aren't selectable (perhaps a bit more complicated than that as the OSM layer doesn't cause this issue). If you turn on those layers and open the drop-down for the select tool they show up as empty gaps in the drop-down.

It also has some odd interactions with the drawing and markup layer. Drawing and Markup now appears in the drop-down. If you add a sketch and then select by drawing and markup it seems to behave as if the sketch tools are active.

[klassenjs]

Can confirm what @chughes-lincoln said.

Turn on WX Radar, Go to Select Features, Click the Layers select box.

Also, with this change Drawing and Markup is now in the list. (I'm not sure this is necessarily a bad thing, but it is likely the result of an unintended side effect).

[theduckylittle]

I have a fix I’ll be pushing. I found the bug on the plane but haven’t been able to push it. 😂

On Thu, Jan 19, 2023 at 13:25 Jim Klassen @.***> wrote:

Can confirm what @chughes-lincoln https://github.com/chughes-lincoln said.

Turn on WX Radar, Go to Select Features, Click the Layers select box.

Also, with this change Drawing and Markup is now in the list. (I'm not sure this is necessarily a bad thing, but it is likely the result of an unintended side effect).

— Reply to this email directly, view it on GitHub https://github.com/geomoose/gm3/pull/786#issuecomment-1397553473, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJZB43PSHT37HVBPN3AUJTWTGPKFANCNFSM6AAAAAATYD73L4 . You are receiving this because you authored the thread.Message ID: @.***>

[theduckylittle]

Added the bug fix and it's captured here. I rebased and squashed my commits so there's not a unique commit for it.