geomoose / gm3

GeoMoose 3.0 Development. Please submit pull requests to the 'main' branch.
https://www.geomoose.org
MIT License
58 stars 59 forks source link

Clicking the select tool highlights identify results #818

Open chughes-lincoln opened 1 year ago

chughes-lincoln commented 1 year ago

If you have identify highlight set to false for a layer, and select highlight set to true, clicking the select tool after an identification highlights all previous results (assuming you didn't clear your results after the identify)

i.e. Turn on pipelines in the demo. Identify a pipeline which doesn't highlight the result because it's set to false. Click Select and the pipeline highlights before you do a selection.

theduckylittle commented 1 year ago

Is this a bug or a feature?

For example, wanting to buffer the feature you just identified?

chughes-lincoln commented 1 year ago

I would say a bug. If the admin wants users to be able to buffer identify results they can just set identify highlight to on.

With the identify tool you also often have several different datasets that are identifiable at once, with often overlapping geometries. Having all these results be highlighted when the user isn't expecting them can be confusing and doesn't provide much value. Clicking the correct result that you want to buffer can also be impossible.

Example below of how it looks with a surveys dataset: image

elil commented 1 year ago

This appears to also impact search (identify then search) which is certainly not a feature :)

I'm wondering about stop-gap measures like invoking a clear results in the beginning of search, select, etc. Hmm, that would also clear results from search or select results that are intended.

chughes-lincoln commented 12 months ago

This also impacts measure (identify then measure).