geomoose / gm3

GeoMoose 3.0 Development. Please submit pull requests to the 'main' branch.
https://www.geomoose.org
MIT License
58 stars 60 forks source link

Refactor of results summary #820

Closed theduckylittle closed 1 year ago

theduckylittle commented 1 year ago

image

image

theduckylittle commented 1 year ago

refs: #588

chughes-lincoln commented 1 year ago

It would be nice if the boxes re-sized themselves to use all the space like in Brent's example.

elil commented 1 year ago

I'm checking if I know what these means: Features: 395 Filtered 457 features from the results

Does this mean that 852 (395+457) features were selected or returned from a search? And then some user interaction filtered 457 features out of those 852 results in the table leaving only 395 features in the table?

chughes-lincoln commented 1 year ago

Yes, the search or selection returns 852 results. Then filtering in the grid removes 457 results leaving 395.

klassenjs commented 1 year ago

The wording seems non-obvious to me. Filtered to me implies the number of results left after filtering rather than the number of results filtered out. To me it would be more natural to list the total number of results, and the number of results shown.

I'll defer to others though if this is good enough as is or should be changed.

klassenjs commented 1 year ago

Bump. Thoughts on the wording?

chughes-lincoln commented 1 year ago

It could be as simple as changing the wording from 'Filtered 457 features from the results.' to '457 results not shown on map due to grid filters'. This ignores whether people should interpret filter as the remaining results or the results being removed.

chughes-lincoln commented 1 year ago

On a related note, should buffering results only be run on the results remaining after a filter?

Currently the buffer tool buffers all results (including results removed by a filter), but it uses the count of the remaining results to determine whether a buffer can be run (you can't buffer more than 100 results at a time).

i.e. if I try to buffer 500 results, it throws an warning telling me I can't buffer that many results. If I filter results to get below 100 results, it allows me to buffer, but it still uses all 500 results.

tchaddad commented 1 year ago

Suggested wording:

"The search returned Z results. X results have been filtered, and the remaining Y results are displayed in the map. "

chughes-lincoln commented 1 year ago

@tchaddad I like the wording, it might help to also say 'X results are filtered out' instead of just filtered.