search

geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
428 stars 489 forks source link

Metadata detail - wrong metadata contact displayed #2312

Closed josegar74 closed 6 years ago

josegar74 commented 6 years ago

In the metadata detail page the metadata contact displayed is from previous record instead of the current one (doesn't seem to happen with the resource contact).

Tested in 3.2.x and 3.4.x:

2 metadata having these metadata contacts:

1) Search for "Salzburg AG Darstellungsdienst" 2) Open the detail page 3) Look up the contact: Salzburg AG (=OK)

4) Click back to search 5) Search for "Tiwag Kraftwerke" 6) Open the detail page 7) Look up the contact: Salzburg AG (= WRONG) 8) Refresh the page 9) The correct contact shows up: TINETZ-Stromnetz Tirol AG

The problem seem with the usage of :: that doesn't re-evaluate the expression in https://github.com/geonetwork/core-geonetwork/blob/3.4.x/web-ui/src/main/resources/catalog/views/default/templates/recordView.html#L364 while for resource contacts is not used like that: https://github.com/geonetwork/core-geonetwork/blob/3.4.x/web-ui/src/main/resources/catalog/views/default/templates/recordView.html#L230

I see several places in that page using ::, @fxprunayre, @fgravin is there any reason for this? or can be removed safely?

fxprunayre commented 6 years ago

This has been fixed in https://github.com/geoadmin/geocat/commit/fb60d53cf8f3099d0fd4003241e8baa3fa1c1983 to backport to 3.4.x. I will do

josegar74 commented 6 years ago

If you don't mind I'll commit to 3.2.x and later we can merge in 3.4.x, some customers using 3.2.x need it @fxprunayre

josegar74 commented 6 years ago

Seem in 3.4.x was pushed already from geoadmin/geocat@fb60d53