geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
428 stars 489 forks source link

useradmin can not assign all group on privileges screen #2470

Closed pvgenuchten closed 6 years ago

pvgenuchten commented 6 years ago

On the privileges screen a user admin can not assign a record to the all group (checkbox disabled), however both reviewer and admin can. Is their some special reason or a bug? A user admin can actually publish the record by selecting publish in the action menu.

Actual code is here https://github.com/geonetwork/core-geonetwork/blob/6645c1980ba99e3e94d1f97db06415f26247083a/web-ui/src/main/resources/catalog/components/common/share/partials/panel.html#L59

Delawen commented 6 years ago

UserAdmin is above Reviewer, so should be able to do the same things as a reviewer, like publish to all group.

pvgenuchten commented 6 years ago

this was not the case... Code was explicitely validating either 'reviewer' or 'administrator' And the value to validate is only the highest level, even if the user is also a reviewer

Delawen commented 6 years ago

Keep this open as:

Now the user interface to create/edit users does not assign all the minor roles to the major role selected. That means: if you create for example a user admin, it does not assign the roles reviewer and editor to it.