Open pvgenuchten opened 5 years ago
added functionality to add a link back to service-metadata from any dataset.
Here I basically restored something which was missing in the Angular app and was the default in 2.x.
and set false by default.
All usages I've seen are with true as default so I would keep it as default. You may want to set isAddingOnlineSrcToDataset to false for maybe 2 reasons:
Other question is, why you add it as onlineresource, and not as a AggregateInformation link?
Because the original idea is to add to the map
To me this makes most sense if we would add the wms/wfs/wcs-service link, but instead we add the link to the xml version of the metadata (afaik in 2.x this added the wms link, and not the metadata link). Adding the vice-versa link to the metadata in this way may work for some configuration that expect this service link here (geonetwork doesn't need it because we index links bi-directional). Do you have any references @fxprunayre to software that uses this convention of linking from dataset to service metadata in this way?
And if somebody uses this convention in geonetwork, is the map indeed able to create an add-to-map scenario following this linkage? Or do you mean adding to the map via manually clicking the service link and then adding to the map?
I guess this issue then relates to https://github.com/geonetwork/core-geonetwork/issues/3035?
I was wondering about usage scenario's in which a dataset-editor does not have privileges on a service record. The most common practice is probably when an IT person is managing the webservice and a dataset maintainer maintains the dataset record. However the IT person should be aware of the dataset he's creating a service for and should manage the linkage between the service and the dataset, the problem may start when the dataset maintainer wants to update the dataset identification. But he probably has to warn the service administrator anyway, because the w*s capabilities will have to reflect the new identification.
An alternative scenario is when a dataset provider notices his dataset (for example openstreetmap) is being exposed by some service and would want to create a link to that service without even engaging with the service provider.
In https://github.com/geonetwork/core-geonetwork/commit/4931202694b12b8a5bc6a1e464b5ab0ce4cea35d#diff-1e61c0195d6858fbeb7cd6227f9df3d3 @fxprunayre added functionality to add a link back to service-metadata from any dataset. It may be relevant for some users, others get confused about this functionality. Apparently there is a flag "isAddingOnlineSrcToDataset" to disable, but it seems hardcoded. Would be good to move this configuration to config.js and set false by default.
Also seem "remove link dataset from service" does not remove the online-resource part from dataset
Other question is, why you add it as onlineresource, and not as a AggregateInformation link?