geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
412 stars 487 forks source link

Inconsistent behaviour of page enabling options in the user interface configuration settings #4224

Open archaeogeek opened 4 years ago

archaeogeek commented 4 years ago

Describe the bug While there are options to enable many interface components (header and footer) and pages (admin, editing etc) in the user interface configuration, some seem to have no effect when disabled (GeoNetwork 3.8.x)

Affected pages:

Furthermore the sign out page application does not have an option to enable/disable.

To Reproduce Steps to reproduce the behavior:

  1. Log in as administrator and go to admin console -> settings -> user interface
  2. Disable the above views by de-selecting their check boxes
  3. Save settings, reload GeoNetwork
  4. See that tabs still appear along top toolbar

Expected behavior Each application should have a check box that enables or disables it correctly

Screenshots Screenshot from 2019-11-27 14-04-04

Log file n/a

Desktop (please complete the following information):

Additional context n/a

fxprunayre commented 4 years ago

Record View

It does not make sense to turn off record view, so we should remove this ? https://github.com/geonetwork/core-geonetwork/commit/533c2d7917e81c75414d4c4d24441cae1dfa340c @MichelGabriel ?

Furthermore the sign out page application does not have an option to enable/disable.

sign in and out work together. Maybe we should move the sign out url in the signin and rename it authentication.

MichelGabriel commented 4 years ago

It does not make sense to turn off record view, so we should remove this ?

Yes, we can remove the select option for record view