search

geonetwork / core-geonetwork

GeoNetwork is a catalog application to manage spatially referenced resources. It provides powerful metadata editing and search functions as well as an interactive web map viewer. It is currently used in numerous Spatial Data Infrastructure initiatives across the world.
http://geonetwork-opensource.org/
GNU General Public License v2.0
412 stars 487 forks source link

Configure via admin panel which INSPIRE conformance classes to run #4568

Open pvgenuchten opened 4 years ago

pvgenuchten commented 4 years ago

Currently it is configured in xml file https://github.com/geonetwork/core-geonetwork/blob/master/services/src/main/resources/config-spring-geonetwork.xml#L90-L119 which conformance classes are implemented under which conditions.

A suggestion would be to create a more dynamic situation where this is configurable from the https://vanilla.geocat.net/geonetwork/srv/eng/admin.console#/metadata/schematron validation admin screen.

The screen could actually query the selected ETF instance to retrieve available conformance classes and let a user select the relevant conformance classes. To offer a certain conformance classes can also be configured to be evaluated with an xpath expression (similar to current schematron configuration).

fxprunayre commented 4 years ago

. To offer a certain conformance classes can also be configured to be evaluated with an xpath expression (

This is done here https://github.com/geonetwork/core-geonetwork/blob/master/services/src/main/resources/config-spring-geonetwork.xml#L128-L135

pvgenuchten commented 4 years ago

@fxprunayre, the point here is that config-spring-geonetwork.xml is hidden within a jar within the war, so quite hard to customize before deployment. It would already be helpfull if the file is a plain xml file within the war. Do you have a suggestion here?

fxprunayre commented 4 years ago

Do you have a suggestion here?

We can probably move it to WEB-INF/config.properties for String and Map bean configuration (https://stackoverflow.com/questions/26275736/how-to-pass-a-mapstring-string-with-application-properties/44529163)

juanluisrp commented 4 years ago

I've moved the configuration to /WEB-INF/config-etf-validator.xml file in PR #4876.